Skip to content

Store credentials in a separate file#1

Open
robbystk wants to merge 4 commits into
masterfrom
credential-file
Open

Store credentials in a separate file#1
robbystk wants to merge 4 commits into
masterfrom
credential-file

Conversation

@robbystk

@robbystk robbystk commented Aug 28, 2018

Copy link
Copy Markdown
Owner

Put credentials (username and API token) into a configuration file rather than storing them in the script itself. This reduces the likelihood of the token accidentally getting uploaded somewhere. This necessitated addition of a new error code in the case that the credential file is not found, which required rearrangement of existing error codes to maintain descending order of checks. Obviously this will break anything relying on the exit status, but nothing does that.

@robbystk robbystk changed the title Credential file Store credentials in a separate file Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant